From 5639160b8b8a0b90db8dfe3eda7be73ac7998416 Mon Sep 17 00:00:00 2001 From: Dominic Barnes Date: Tue, 23 Jan 2018 13:51:41 -0800 Subject: [PATCH] feat(git-release): push tags first to help ci tools not miss them If you are buliding on CircleCI for example, pushing the commits first can lead to a race where CI env will not see the tags since the pull happened before the tags were finished pushing. It should be fully safe (and backwards-compatible) to change the order of pushing to the remote. --- bin/git-release | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/git-release b/bin/git-release index 3585a08..2ff2570 100755 --- a/bin/git-release +++ b/bin/git-release @@ -91,8 +91,8 @@ if test $# -gt 0; then git commit -a -m "$msg" # shellcheck disable=SC2086 git tag $version -a -m "$msg" \ - && git push $remote \ && git push $remote --tags \ + && git push $remote \ && hook post-release $hook_args \ && echo "... complete" else