From 082d12b1f40d399008a7869ebaf15a62970ea2b1 Mon Sep 17 00:00:00 2001 From: Daisuke Maki Date: Sun, 8 Mar 2026 10:28:35 +0900 Subject: [PATCH] fix more doc inaccuracies from copilot review --- .claude/docs/cli.md | 2 +- .claude/docs/packages.md | 2 +- .claude/docs/testing.md | 6 +++--- CLAUDE.md | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.claude/docs/cli.md b/.claude/docs/cli.md index 32e7416..ccde4d9 100644 --- a/.claude/docs/cli.md +++ b/.claude/docs/cli.md @@ -22,7 +22,7 @@ | `--layout` | string | Layout type: top-down, bottom-up, top-down-query-bottom | | `--select-1` | bool | Auto-select if single match | | `--exit-zero` | bool | Exit immediately with status 1 if input is empty | -| `--select-all` | bool | Select all lines initially | +| `--select-all` | bool | Select all lines and exit immediately | | `--on-cancel` | string | Cancel behavior: success/error | | `--selection-prefix` | string | Prefix for selected lines | | `--exec` | string | Command to execute with selection | diff --git a/.claude/docs/packages.md b/.claude/docs/packages.md index 42bacca..9605685 100644 --- a/.claude/docs/packages.md +++ b/.claude/docs/packages.md @@ -57,7 +57,7 @@ Filter algorithm implementations. - **Filter** interface — `Apply(ctx, []line.Line, ChanOutput) → error`, `BufSize() → int`, `NewContext(ctx, string) → ctx`, `String() → string`, `SupportsParallel() → bool` - **Collector** interface (optional) — `ApplyCollect(ctx, []line.Line) → ([]line.Line, error)` - **Set** — filter collection with rotation: `Add(Filter)`, `Rotate()`, `Current() → Filter`, `SetCurrentByName(string) → error` -- Implementations: `NewIgnoreCase()`, `NewCaseSensitive()`, `NewSmartCase()`, `NewRegexp()`, `NewIRegexp()`, `NewFuzzy(longestSort bool)`, `NewExternalCmd(name, cmd string, args []string, threshold int, idgen IDGenerator, enableSep bool)` +- Implementations: `NewIgnoreCase()`, `NewCaseSensitive()`, `NewSmartCase()`, `NewRegexp()`, `NewIRegexp()`, `NewFuzzy(sortLongest bool)`, `NewExternalCmd(name, cmd string, args []string, threshold int, idgen IDGenerator, enableSep bool)` - Files: `filter.go`, `base.go`, `regexp.go`, `fuzzy.go`, `external.go`, `set.go` - Imports: line, pipeline, internal/util diff --git a/.claude/docs/testing.md b/.claude/docs/testing.md index 7d89f13..f0fd003 100644 --- a/.claude/docs/testing.md +++ b/.claude/docs/testing.md @@ -18,9 +18,9 @@ go test -race -coverprofile=coverage.out ./... # coverage ## Key Test Helpers -- `newPeco() → *Peco` — creates test instance with DummyScreen, default config -- `NewDummyScreen() → *DummyScreen` — mock terminal; supports `SendEvent(Event)` for input injection -- DummyScreen has fixed size, no-op rendering, collects events +- `newPeco() → *Peco` — creates test instance with SimScreen, default config +- `NewDummyScreen() → *SimScreen` — mock terminal; supports `SendEvent(Event)` for input injection +- SimScreen has fixed size, no-op rendering, collects events ## Test Patterns diff --git a/CLAUDE.md b/CLAUDE.md index d671205..5f0b8b5 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -75,7 +75,7 @@ Uses `google/btree` for ordered selection storage. Supports multi-select, range ### Platform-Specific Code -Files suffixed `_posix.go` / `_windows.go` in `screen.go` and `internal/util/` handle TTY detection, shell integration, and home directory resolution per platform. +Platform-specific behavior lives in `layout_any.go` / `layout_windows.go` (handling the `extraOffset` layout constant) and in files suffixed `_posix.go` / `_windows.go` under `internal/util/` (TTY detection, shell integration, home directory resolution). ### Code Generation