utils-shell/peco.peco
1
0
Fork 0
mirror of https://github.com/peco/peco.git synced 2026-09-10 07:16:29 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #759 from peco/fix-resultch-race

Browse source 
fix data race on resultCh in PrintResults
This commit is contained in:
lestrrat 2026-02-20 22:29:51 +09:00 committed by GitHub
parent e4e92ad5ac 720f1b0be8
commit 98f51cbbf5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
peco.go
View file

@ -1086,11 +1086,12 @@ func (p *Peco) PrintResults() {
selection.Add(l)
}
}
p.SetResultCh(make(chan line.Line))
resultCh := make(chan line.Line)
p.SetResultCh(resultCh)
go func() {
defer close(p.resultCh)
defer close(resultCh)
p.selection.Ascend(func(l line.Line) bool {
p.ResultCh() <- l
resultCh <- l
return true
})
}()
@ -1104,7 +1105,7 @@ func (p *Peco) PrintResults() {
buf.WriteString(p.Query().String())
buf.WriteByte('\n')
}
for line := range p.ResultCh() {
for line := range resultCh {
buf.WriteString(line.Output())
buf.WriteByte('\n')
}