Daisuke Maki
e2bc390c68
fix: merge two context keys into one in Hub.Batch
...
Reduce context.WithValue calls from 2 to 1 per Batch invocation.
| Metric | Before | After | Delta |
|------------|--------|-------|-------|
| allocs/op | 3 | 2 | -1 |
| B/op | 128 | 80 | -48 |
| ns/op | ~372 | ~352 | -5% |
2026-02-21 22:20:25 +09:00
lestrrat
82a4d605b7
Merge pull request #773 from peco/fix-hub-pool-comment
...
add comment explaining pool type assertion safety
2026-02-21 08:04:06 +09:00
Daisuke Maki
8c4db9e026
convert t.Errorf/t.Fatal to testify/require
2026-02-21 07:58:26 +09:00
Daisuke Maki
e024c7a01e
add comment explaining pool type assertion safety
2026-02-21 07:58:14 +09:00
Daisuke Maki
c404f05d43
use require instead of t.Errorf in hub tests
2026-02-20 22:47:52 +09:00
Daisuke Maki
fc18c0d3de
Methodically add function comments
2026-02-20 10:55:49 +09:00
Daisuke Maki
95e13933c2
Do away with interface.go files
2026-02-18 21:12:19 +09:00
lestrrat
fa5cc8aa9d
Merge pull request #690 from peco/fix-hub-batch-locking
...
Replace shouldLock with context-based re-entrancy
2026-02-18 11:31:30 +09:00
Daisuke Maki
57d6761a9f
Replace shouldLock with context-based re-entrancy
2026-02-18 11:25:42 +09:00
Daisuke Maki
1f218ae97e
Remove dead code
2026-02-18 09:44:47 +09:00
Daisuke Maki
46331edcfd
Check for far wider range of things in lint
2026-02-18 07:49:40 +09:00
lestrrat
32f69ee127
Merge pull request #669 from peco/fix-unguarded-pdebug
...
fix unguarded debug prints
2026-02-17 19:30:29 +09:00
Daisuke Maki
4f795dc6cb
fix unguarded debug prints
2026-02-17 19:16:39 +09:00
lestrrat
44780a2518
Merge pull request #661 from peco/remove-hub-issync
...
remove unused
2026-02-17 19:02:13 +09:00
Daisuke Maki
055b7c3bbc
remove unused
2026-02-17 18:54:39 +09:00
Daisuke Maki
4ad0bc31c6
Avoid hub.Batch swalloing panics
2026-02-17 18:11:47 +09:00
Daisuke Maki
c3c4116dc0
Check for generated files
2026-02-17 18:03:46 +09:00
Daisuke Maki
dfe6f1e775
make this operation safer. (not necessarily a problem)
2026-02-17 11:06:33 +09:00
Daisuke Maki
7cd4b18817
Refactor context usage around hub.send
2026-02-17 09:53:29 +09:00
Daisuke Maki
ffc3e85bd0
consolidate SendStatusMsg
2026-02-17 07:17:45 +09:00
Daisuke Maki
12a55491ef
Change Hub structure to take typed payloads
2026-02-16 22:40:34 +09:00
Yasuhiro Matsumoto
c1ffd8b128
go fmt ./...
2026-02-14 17:36:53 +09:00
Daisuke Maki
db63d9f380
Add linting fixes
2026-02-14 07:48:23 +09:00
Daisuke Maki
b749b6191b
some cleanups
2020-01-10 12:19:44 +09:00
Daisuke Maki
71c4c48efe
properly set the requested value
2020-01-10 11:57:28 +09:00
Daisuke Maki
305a208ca2
remove non-applicable comments/commented sections/debug statements
2020-01-10 11:55:12 +09:00
Daisuke Maki
43ee9051f8
Fix blocking issue cased by #491
...
... by punting the problem when the input is an infinite stream.
This commit fixes the blocking, but the subsequent queries don't seem
to be properly running
refs #494
2020-01-09 20:22:18 +09:00
Daisuke Maki
d02bb4122c
Workaround glide being stubborn wrt lestrrat/go-pdebug -> lestrrat-go/pdebug
2018-10-25 09:50:16 +09:00
Daisuke Maki
987e844ba2
Fix the test
2016-10-01 08:02:23 +09:00
Daisuke Maki
25d942b08b
Add notion of "top-level" actions
...
This is used to by-pass locking the hub.Batch operation when
we have nested action calls that use batching internally.
fixes #345
2016-09-30 18:20:25 +09:00
Daisuke Maki
821af182ab
reinstate single key jump
...
the caching was more agressive than before, and we forgot to
initialize the structure correctly
TODO: Write tests to catch this
fixes #331
2016-08-22 17:56:32 +09:00
Daisuke Maki
87b4ad48a0
fix to work with new pipeline
2016-08-18 11:04:40 +09:00
Daisuke Maki
406cfe3bd7
Trying to get rid of "everything is a Ctx"
2016-06-18 17:39:02 +09:00