x11-misc/neovide.neovide
1
0
Fork 0
mirror of https://github.com/neovide/neovide.git synced 2026-09-10 07:16:25 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: render the correct message window geometry (#3430)

Browse source 
note: neovim reports message grids with the full default-grid height even when only
the bottom few rows are actually on screen.

f2d0b06ecb/src/nvim/message.c?plain=1#L205-L254

we were already compensating for that in one place when clamping the target
position, but then we turned around and used the full backing-grid size for
pixel_region()

that means the renderer still treated the message window as if
all rows were visible, which is wrong.

https://github.com/neovide/neovide/issues/3427
This commit is contained in:
Alexsander Falcucci 2026-03-30 14:06:06 +02:00 committed by GitHub
parent b943884298
commit a76304c7ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/renderer/rendered_window.rs
View file

@ -153,7 +153,18 @@ impl RenderedWindow {
// characters.
let fract = (self.grid_destination * grid_scale).fract();
let pos = (self.grid_current_position * grid_scale - fract).round() + fract.to_vector();
PixelRect::<f32>::from_origin_and_size(pos.into(), self.grid_size * grid_scale)
PixelRect::<f32>::from_origin_and_size(pos.into(), self.grid_size() * grid_scale)
}
fn grid_size(&self) -> GridSize<u32> {
let mut size = self.grid_size;
if matches!(self.window_type, WindowType::Message { .. }) {
// Neovim reports message grids with the full default-grid height even
// when they are anchored near the bottom. Only the rows from the
// message start row down to the bottom edge are actually visible.
size.height = size.height.saturating_sub(self.grid_destination.y.max(0.0) as u32);
}
size
}
fn get_target_position(&self, grid_rect: &GridRect<f32>) -> GridPos<f32> {
@ -163,13 +174,7 @@ impl RenderedWindow {
None => destination,
Some(AnchorInfo { anchor_type: WindowAnchor::Absolute, .. }) => destination,
_ => {
let mut grid_size: GridSize<f32> = self.grid_size.try_cast().unwrap();
if matches!(self.window_type, WindowType::Message { .. }) {
// The message grid size is always the full window size, so use the relative position to
// calculate the actual grid size
grid_size.height -= self.grid_destination.y;
}
let grid_size: GridSize<f32> = self.grid_size().try_cast().unwrap();
// If a floating window is partially outside the grid, then move it in from the right, but
// ensure that the left edge is always visible.
let x = destination.x.min(grid_rect.max.x - grid_size.width).max(grid_rect.min.x);