Commit graph

17 commits

Author SHA1 Message Date
Nyx e530d43131
Fix select-from-menu crashing X (#1029)
* add default *menu-maximum-height* value

* Update documentation

* document setting nil for *menu-maximum-height*
2022-08-24 20:59:07 -06:00
Spenser Truex 70331ec1d9 Documentation fixes and capitalization
* the "Default" group name should no be capitalised since the completion is
  case-sensitive.
* Docstrings are better than function-documenting comments.
* English sentences should be capitalised on the first word only.
2019-12-21 15:56:29 -08:00
sdilts 03cf362056 Fix spelling in menu-prompt-line 2018-06-23 13:13:37 -06:00
sdilts d00765ebba Fixed compilation errors
+ Makefile no longer expects menu.lisp
+ export statements are now correct
2018-06-22 20:12:22 -06:00
sdilts 4391b3bd59 Spellcheck and cleanup comments 2018-06-22 18:59:55 -06:00
sdilts e2bec1f5af Clean up comments 2018-06-22 18:01:00 -06:00
sdilts 96aca005b1 Export commands, variables;change name of selection-menu
+ Exported commands and variables needed for customizations and
  building menus.
+ selection-menu isn't a very good name for the new menu type;
  command-menu is slightly better
2018-06-22 17:01:42 -06:00
sdilts 0152e00cae Implemented selection-menu
Also changed the copywrites to reflect who actually authored the code.
+ selection menu is the higher-level function to batch menu; see the
  comments for how it should be used.
+ #\u in batch-menu now has the correct behavior; the cursor needs to
  move down once an item is unselected.
2018-06-10 19:40:11 -06:00
sdilts e4e7ec39dc select-from-batch-menu is implemented 2018-05-08 20:04:59 -06:00
sdilts 300f88f93e Adde menu-entry class 2018-05-08 17:41:34 -06:00
sdilts 5bd3f7b048 Prefer with-accessors over with-slots, improve menu initialization
+ Change menu initialization to use keyword arguments to specify the
  initial keymap
2018-05-08 11:28:05 -06:00
sdilts f46f962a9d Searching single-menu works now
+ Confusion over using filtered vs. unfiltered table
  - chose to store the whole table in the unfiltered variable, and
  have the table variable hold the filtered version, as that was how
  it was previously. Plus, `bound-check-menu` won't need to be changed.

+ use menu-backspace instead of the non-existent single-menu-backspace

+ As the function works now, change `my-select-from-menu` to `select-from-menu`
2018-05-06 17:10:38 -06:00
sdilts c42b7892ed Fixed warnings, typos, and improved style
+ There were a few parentheses missing

+ initial arguments weren't quite right for both classes

+ initialization didn't produce the correct result for the keymap in
  single-menu

+ use &key instead of &optional in initialize-instance

+ Move *menu-map* and *single-menu-map* to avoid warnings

+ Removed duplicate functions
2018-05-06 17:09:43 -06:00
sdilts 2859e65422 More cleanup of docs and commented code 2018-05-05 22:52:23 -06:00
sdilts 14c8b50900 Implemented generic functions, moved menu functions
+ Nothing is tested: need to replace current impleneation to compile
  correctly

+ Ready to test!
2018-05-05 22:49:53 -06:00
sdilts 7703d4290b Cleaned up documentation, made some decisions on generic functions
+ Clarified documentation
+ Removed some functions that should not be generic functions
2018-05-05 19:38:36 -06:00
sdilts 25edd464ed Built a generic menu framework
+ This commit is essentialy a transformation of what is currently in
  menu.lisp so that the code can be re-used for multiple different
  menu types.

+ the menu class is most generic; accounts for moving around the menu
  and basic display.

+ the single-menu class implements the select-from-menu functionality

+ Hasn't been tested, no generic methods are realized yet.

+ Not all functions from menu.lisp have been transformed into generic
  functions, as they are helper functions.
2018-05-02 19:53:12 -06:00