Marco Baringer
d47464e23b
Require non-empty captures in the four field regexps
...
denote-{identifier,signature,title,keywords}-regexp used a lazy
zero-or-more capture ([^.]*?), so they matched the bare separator
followed by an extension, e.g. __.js, --.org, ==.org, @@.org. Combined
with denote-file-has-denoted-filename-p, this meant such files were
treated as valid denote notes. lodash's node_modules ships __.js files,
which made a denote-directory containing a lodash checkout enumerate
junk candidates in the file prompt (and previously crash, see preceding
commit).
Switch to a non-empty lazy capture ([^.]+?) so the field must contain at
least one character.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-23 16:20:49 +02:00
Marco Baringer
6ba209704d
Fix file-prompt crash when denote-directory contains files like __.js
...
Using denote in a directory that includes files matching '*/__.js'
breaks with "Wrong type argument: stringp, nil" on the file prompt.
lodash ships such files in node_modules, so accidentally pointing
denote at a lodash checkout (or having one under denote-directory)
triggers the error.
These files pass denote-file-has-denoted-filename-p because the empty
keywords section matches denote-keywords-regexp, but they have no
identifier, so denote-file-prompt--format-identifier passed nil to
propertize during affixation. Return nil in that case;
denote-file-prompt-affixate already substitutes "" for a nil prefix.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-23 16:17:47 +02:00
Protesilaos
30c0d6536e
Be precise in the denote-file-prompt-extra-metadata docstring
2026-05-21 20:09:22 +03:00
Protesilaos
13b2164369
Update to Denote version 4.2.0
2026-05-20 15:41:08 +03:00
Protesilaos
e40bdc8cdc
Remove spacing in denote--get-front-matter-rewrite-prompt
2026-05-20 15:24:30 +03:00
Protesilaos
3ef7380190
Remove the denote-sort-dired-focus alias
...
I want to reach a point where only denote-dired and related are used.
Maybe this is more appropriate for the next major version, but I can
do it here since this is a new command.
2026-05-20 12:37:13 +03:00
Protesilaos
ea398e9a2a
Throw a user-error if denote-dired-focus is called in a Dired buffer without prior denote-dired
2026-05-20 12:35:57 +03:00
Protesilaos
dbfe4b189a
Remove faulty 'or' from denote--dir-in-denote-directory-p
...
Thanks to Jean-Philippe Gagné Guay for pointing out the problem with
it in a comment to issue 705:
<https://github.com/protesilaos/denote/issues/705#issuecomment-4436808008 >.
2026-05-13 11:12:45 +03:00
Protesilaos
3f5ede71d4
Reindent denote-valid-date-p
2026-05-12 13:26:37 +03:00
Protesilaos
1aedcff2d7
Make stylistic tweaks to denote--prepare-note
2026-05-12 13:25:01 +03:00
Protesilaos
59eea50d4b
Reindent denote--valid-file-type
2026-05-12 13:22:35 +03:00
Protesilaos
21b1c81d1a
Make denote--dir-in-denote-directory-p more robust
...
This is in response to a bug reported by Kevin Izevbigie in issue 705:
<https://github.com/protesilaos/denote/issues/705 >.
2026-05-12 13:18:27 +03:00
Protesilaos
d7dab477a1
Document the denote-lint package
2026-05-01 18:56:52 +03:00
Protesilaos
0ff9573362
Make stylistic refinements to the helpers introduced in 8e6d83c
...
I was testing them and was too eager to commit before refining them.
Will need to write tests eventually, but I do not have time right now.
2026-05-01 18:48:34 +03:00
Protesilaos
8e6d83c652
Make rename commands not interfere with existing front matter indentation
...
This is to address the comment posted by Morten Kjeldgaard in issue
703: <https://github.com/protesilaos/denote/issues/703 >.
2026-05-01 18:40:39 +03:00
Protesilaos
06c520de36
Do for the keyword include/exclude commands the same as commit 9b8c96f
2026-04-28 23:31:03 +03:00
Protesilaos
9b8c96f5e8
Redefine denote-query-only-include-files and denote-query-exclude-files to use helper function
...
The macro we had before was okay, but this feels easier to reason about.
2026-04-28 23:27:03 +03:00
Protesilaos
d78ad3f74e
Make denote-link-ol-store work in org-capture as well
...
This affects the org-capture specifiers that create a link such as %a
and %l.
Thanks to jarofromel for bringing this matter to my attention in
discussion 702: <https://github.com/protesilaos/denote/discussions/702 >.
2026-04-28 22:56:36 +03:00
Protesilaos
8112e65bc3
Acknowledge nescias for commit c772378
...
This was sent to me as a patch via email. The change is small, meaning
that its author does not need to assign copyright the Free Software
Foundation.
2026-04-28 18:47:30 +03:00
nescias
c7723784b9
Fix typos in documentation
2026-04-28 17:24:36 +03:00
Protesilaos
b5be053380
Document the ~denote-wordcloud package
2026-04-27 23:16:11 +03:00
Protesilaos
f113e49988
Document the denote-sections package by Samuel W. Flint
...
Thanks to Samuel for bringing this matter to my attenion in issue 701:
<https://github.com/protesilaos/denote/issues/701 >.
2026-04-27 22:47:57 +03:00
Protesilaos
3cd8d47c00
Document the denote-regexp package by Samuel W. Flint
...
Thanks to Samuel for bringing this matter to my attenion in issue 701:
<https://github.com/protesilaos/denote/issues/701 >.
2026-04-27 22:45:51 +03:00
Protesilaos
348d851eb4
Document the denote-project-notes package by Samuel W. Flint
...
Thanks to Samuel for bringing this matter to my attenion in issue 701:
<https://github.com/protesilaos/denote/issues/701 >.
2026-04-27 22:36:42 +03:00
Protesilaos
7babe195ee
Document the denote-agenda package by Samuel W. Flint
...
Thanks to Samuel for bringing this matter to my attenion in issue 701:
<https://github.com/protesilaos/denote/issues/701 >.
2026-04-27 22:32:25 +03:00
Protesilaos
aedbb0cecd
Document the denote-journal-capture package by Samuel W. Flint
...
Thanks to Samuel for bringing this matter to my attenion in issue 701:
<https://github.com/protesilaos/denote/issues/701 >.
2026-04-27 22:25:58 +03:00
Protesilaos
97ffb56320
Use "Protesilaos" instead of "Protesilaos Stavrou"
...
As I announced here: <https://protesilaos.com/news/2026-04-21-omitting-the-surname/ >.
2026-04-24 13:26:01 +03:00
Protesilaos
7574b8cecd
Document in the manual the functions to get the file type for YAML and TOML
2026-04-23 21:25:34 +03:00
Protesilaos
29fd39a4d4
Make sure the denote-file-type function is registered in the function index
2026-04-23 21:25:14 +03:00
Protesilaos
87a4a02afa
Document denote-file-type function in the manual
2026-04-23 21:19:57 +03:00
Protesilaos
dd4551ad9c
Rewrite the doc string of denote-file-type
2026-04-23 21:17:20 +03:00
Protesilaos
231d7d64e8
Write a test for denote-file-type
2026-04-23 21:02:08 +03:00
Protesilaos
ee1ad314fc
Add :get-file-type-function to the denote-file-type function
2026-04-23 21:01:38 +03:00
Protesilaos
8b9a4e511d
Add a :get-file-type-function to the denote-file-types
2026-04-23 21:00:59 +03:00
Protesilaos
5281b7c3fc
Add a comment related to where denote--title-value-reverse-function is called
2026-04-23 19:55:38 +03:00
Protesilaos
207a365b83
Expand the TODO comment about denote-file-type
2026-04-23 19:30:51 +03:00
Protesilaos
568c807d8d
Add a TODO about denote-file-type
2026-04-23 19:27:16 +03:00
Protesilaos
ec4fed24f7
Prevent denote-retrieve-xref-alist-for-backlinks from throwing an error if file type is nil
2026-04-23 19:09:09 +03:00
Protesilaos
383c52be8d
Acknowledge GuutBoy for reporting a bug in denote-markdown
...
This was done in issue 699: <https://github.com/protesilaos/denote/issues/699 >.
2026-04-23 19:07:39 +03:00
Protesilaos Stavrou
5e995cfecc
Acknowledge gnuhack for commit aaa75e7
...
This was done as part of pull request 697: <https://github.com/protesilaos/denote/pull/697 >.
The change is small, repurposing existing code, meaning that the
author does not need to assign copyright to the Free Software Foundation.
2026-04-21 08:38:09 +03:00
Protesilaos Stavrou
59e1304a67
Merge pull request #697 from gnuhack/patch-2
...
Macro for denote-query-exclude-files and denote-query-only-include-files
2026-04-21 08:37:08 +03:00
gnuhack
aaa75e7f13
Macro for denote-query-exclude-files and denote-query-only-include-files
...
Replaced both functions with a new macro. Created the new functions through the macro.
2026-04-20 12:47:02 +02:00
Protesilaos Stavrou
c3b60fcada
Replace "doc string" with "docstring"
2026-04-13 08:41:39 +03:00
Protesilaos Stavrou
f6499cbf5c
Merge branch 'main' of github.com:protesilaos/denote
2026-04-09 21:16:03 +03:00
Protesilaos Stavrou
0993df4fbc
Fix typo about "keymap"
2026-04-09 21:11:40 +03:00
Protesilaos Stavrou
b77b926505
Merge pull request #696 from gnuhack/patch-1
...
Fix typo
2026-04-09 08:19:36 +03:00
gnuhack
63c052e1ac
Fix typo
2026-04-09 00:09:56 +02:00
Protesilaos Stavrou
160444b853
Mention denote-dired-focus in the manual and expand its docstring
2026-04-07 12:11:54 +03:00
Protesilaos Stavrou
4483caee95
Update the manual's acknowledgements
...
This is about the idea behind denote-dired-focus, as discussed in
issue 693: <https://github.com/protesilaos/denote/issues/693 >.
2026-04-07 12:03:23 +03:00
Protesilaos Stavrou
b4924c853d
Make denote-sort-dired always produce a new buffer
...
Thanks to 82Kang for telling me about the use-case of maintaining
multiple Denote Dired buffers side-by-side. This is done as part of
issue 693: <https://github.com/protesilaos/denote/issues/693 >.
2026-04-07 11:55:38 +03:00
