I don't know about you, but I just found my new favourite:
(setq modus-themes-common-palette-overrides
'((mail-cite-0 fg-dim)
(mail-cite-1 fg-alt)
(mail-cite-2 fg-dim)
(mail-cite-3 fg-alt)
(mail-part yellow-cooler)
(mail-recipient green-cooler)
(mail-subject red-cooler)
(mail-other green)))
I will explain everything on my website as well as the change log,
once version 4.0.0 is released. What I have here is not final and I
am still testing for regressions.
This is based on merge request 44 by Xinglu Chen on the GitLab mirror
from 2021-06-16:
<https://gitlab.com/protesilaos/modus-themes/-/merge_requests/44>.
That contribution could not be merged, as it exceeded the ~15 line
limit and thus required copyright assignment to the Free Software
Foundation. The author became inactive soon thereafter despite their
stated intention to do the paperwork.
Thanks to Laith Bahodi for informing me about this in issue 48 on the
GitHub mirror: <https://github.com/protesilaos/modus-themes/issues/48>.
In principle, the agda project should be inheriting from font-lock
faces instead of hardcoding their own colour values: those do not play
nicely with themes. If anyone familiar with agda reads this, I
encourage you to work with upstream to make things better for all
themes. Also consider that adga cannot be tested without an
established setup for Haskell, which adds to the burden of maintaining
those faces at the theme level (I could not test them and only went by
screenshots and prior experience).
This was done in pull request 47 on the GitHub mirror:
<https://github.com/protesilaos/modus-themes/pull/47>.
The contribution is on a single line and this is Aleksei's first
contribution to this project. It thus does not require copyright
assignment to the Free Software Foundation.
This is to make the export to texinfo output:
@code{nil}
Instead of a generic "nil".
This was already done in most placed, but some had escaped my
attention. I was reminded to check again by commit 0f39eb3, courtesy
of Stefan Kangas.
The previous style did not actually hide the fringes, as olivetti
would still fall back to reading the generic fringe face.
The intent of this change is to make the olivetti-fringe invisible.
Thanks to Matthias Fuchs for reporting the issue that helped me track
this problem. This was done in issue 46 on the GitHub mirror:
<https://github.com/protesilaos/modus-themes/issues/46>.
We cannot use our ordinary entries from each theme's palette as those
are not designed to handle such an edge case. Those faces need to use
the inverse-video attribute which, in turn, affects the combinations
of color we can apply. Our accented backgrounds are designed to
contrast well with our nominal main foreground values, whereas this
case demands colored backgrounds that contrast well with what would
normally be the main background color. Furthermore, this case
requires that colored backgrounds are faithful to their name so that,
say, hi-yellow is yellowish.
Thanks to Kevin Kainan Li for the feedback on the mailing list, where
they informed me that the previous design was too dark/mute (and I
agreed with that assessment) and provided feedback on my samples:
<https://lists.sr.ht/~protesilaos/modus-themes/%3CCAMTq2Vp3Nnzv-i9wJdq4-OJ4X_QfWXySpUtAieBy0dgKLEOSBg%40mail.gmail.com%3E>.
