mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-09-11 08:06:25 -04:00
cf89ef9d4f
The reveal advanced the selection by capturing the next/previous change as a patch identity and finding it again after the re-render. No line-number identity is stable and unique across a stage, though: a deletion shares its new-file number with the rest of its block (so staging one deletion of a block landed back on the block's first line), and in the staged pane the new-file number is the index, which staging/unstaging shifts (so unstaging a modification's deletion missed its replacement line and fell back to an earlier block). The previous worktree-line and adjacent-change-line matching each fixed one case and left another. Do instead what the staging view does: preserve the selection's ordinal among change lines. Read the acted-on line's ordinal from the pane it was in before the op; after the re-render, select the change line at that ordinal in the target pane (clamped to the last). Since the op removes the acted-on change line(s), that ordinal then holds the next surviving change — the next line of the same block, or the next block when a whole block was staged. This needs no reasoning about which side's line numbers are stable, so it handles deletions and the staged pane uniformly. The matching machinery (matchByWorktreeChange, AdjacentChangeLine) is gone; the identity-matched restore (escape, -U preserve) and the new positional restore now share installDiffLineRestore. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| amend_helper.go | ||
| app_status_helper.go | ||
| bisect_helper.go | ||
| branches_helper.go | ||
| cherry_pick_helper.go | ||
| commit_files_helper.go | ||
| commits_helper.go | ||
| commits_helper_test.go | ||
| confirmation_helper.go | ||
| credentials_helper.go | ||
| diff_helper.go | ||
| diff_line_navigation.go | ||
| diff_line_navigation_test.go | ||
| diff_line_parser.go | ||
| diff_line_parser_test.go | ||
| drag_autoscroller.go | ||
| drag_autoscroller_test.go | ||
| files_helper.go | ||
| fixup_helper.go | ||
| fixup_helper_test.go | ||
| gpg_helper.go | ||
| helpers.go | ||
| host_helper.go | ||
| inline_status_helper.go | ||
| menu_key.go | ||
| merge_and_rebase_helper.go | ||
| merge_conflicts_helper.go | ||
| mode_helper.go | ||
| patch_building_helper.go | ||
| record_directory_helper.go | ||
| refresh_helper.go | ||
| refresh_helper_test.go | ||
| refs_helper.go | ||
| repos_helper.go | ||
| search_helper.go | ||
| signal_handling.go | ||
| signal_handling_windows.go | ||
| snake_helper.go | ||
| staging_helper.go | ||
| sub_commits_helper.go | ||
| suggestions_helper.go | ||
| suspend_resume_helper.go | ||
| tags_helper.go | ||
| update_helper.go | ||
| upstream_helper.go | ||
| upstream_helper_test.go | ||
| view_helper.go | ||
| window_arrangement_helper.go | ||
| window_arrangement_helper_test.go | ||
| window_helper.go | ||
| working_tree_helper.go | ||
| worktree_helper.go | ||
| worktree_helper_test.go | ||