mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-09-11 16:16:28 -04:00
88dae2f2c6
Each command a side panel handles in the focused main view needed its own delegation channel: a HasKeybindings getter, an IBaseContext Add method, a BaseContext field + getter, a baseController nil default, and an attach.go registration — roughly five touch points per command. With three commands (click, stage, toggle-patch) that was already a lot of boilerplate, and it doesn't scale to the discard / copy commands coming next. Replace the three channels with one: a side panel exposes a single FocusedMainViewActions interface via GetFocusedMainViewActions (nil when its diff offers no actions), and the controllers implement that interface directly. The stage and toggle-patch handlers, already unified to a plain error return, become one PrimaryAction method whose meaning is the panel's business (stage for the files panel, patch toggle for the commit panels); the click handler becomes OnClick. MainViewController is now a thin dispatcher: fetch the actions from the panel beneath, call the method. Adding a command is now one interface method, an implementation in the two or three controllers, and a keybinding — no plumbing. The toggle-patch channel did double duty as the "this panel builds a custom patch" signal for the inclusion gutter (shown only beneath a patch-building panel, not the staging files panel). Collapsing the channels removes that proxy, so make the classification explicit on DiffMainViewContext, whose marker method now returns a DiffMainViewType (none / staging / patch-building) instead of being a bare marker. The gutter shows only beneath a panel whose type is patch-building (commit files, local commits, sub-commits, stash). Behavior-preserving. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| traits | ||
| base_context.go | ||
| branches_context.go | ||
| commit_files_context.go | ||
| commit_message_context.go | ||
| confirmation_context.go | ||
| context.go | ||
| context_common.go | ||
| dynamic_title_builder.go | ||
| filtered_list.go | ||
| filtered_list_view_model.go | ||
| history_trait.go | ||
| list_context_trait.go | ||
| list_renderer.go | ||
| list_renderer_test.go | ||
| list_view_model.go | ||
| local_commits_context.go | ||
| local_commits_context_test.go | ||
| main_context.go | ||
| menu_context.go | ||
| merge_conflicts_context.go | ||
| parent_context_mgr.go | ||
| patch_explorer_context.go | ||
| prompt_context.go | ||
| reflog_commits_context.go | ||
| remote_branches_context.go | ||
| remotes_context.go | ||
| search_trait.go | ||
| setup.go | ||
| simple_context.go | ||
| stash_context.go | ||
| sub_commits_context.go | ||
| submodules_context.go | ||
| suggestions_context.go | ||
| tags_context.go | ||
| view_trait.go | ||
| working_tree_context.go | ||
| worktrees_context.go | ||