mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-09-10 07:36:27 -04:00
4e907c6b3e
The model<->view index conversions were derived from arrays that only renderLines populated. That made them depend on the list having been rendered (so a conversion before the first render ignored the non-model items), and it made them go stale whenever the model changed after a render: converting an index then returned a wrong result, and once the model had grown past the last rendered length the conversion indexed a too-short array and panicked (seen in cherry_pick under -race). The conversion is a pure function of the current list length and the current non-model items, and needs none of the rendered display strings. Compute it directly and drop the cached arrays, so the result is always consistent with the current model and no longer depends on rendering. searchModelCommits converts every commit's index, and building the non-model items can be O(len) mid-rebase, so it would now be quadratic; snapshot the non-model items once via modelToViewIndexConverter instead of rebuilding them per index. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| traits | ||
| base_context.go | ||
| branches_context.go | ||
| commit_files_context.go | ||
| commit_message_context.go | ||
| confirmation_context.go | ||
| context.go | ||
| context_common.go | ||
| dynamic_title_builder.go | ||
| filtered_list.go | ||
| filtered_list_view_model.go | ||
| history_trait.go | ||
| list_context_trait.go | ||
| list_renderer.go | ||
| list_renderer_test.go | ||
| list_view_model.go | ||
| local_commits_context.go | ||
| main_context.go | ||
| menu_context.go | ||
| merge_conflicts_context.go | ||
| parent_context_mgr.go | ||
| patch_explorer_context.go | ||
| prompt_context.go | ||
| reflog_commits_context.go | ||
| remote_branches_context.go | ||
| remotes_context.go | ||
| search_trait.go | ||
| setup.go | ||
| simple_context.go | ||
| stash_context.go | ||
| sub_commits_context.go | ||
| submodules_context.go | ||
| suggestions_context.go | ||
| tags_context.go | ||
| view_trait.go | ||
| working_tree_context.go | ||
| worktrees_context.go | ||